qt: create windows desktop shortcut during installation #3003
Conversation
|
@benma please have a look. I looked into whether it is possible to add a checkbox to the last screen to create a shortcut, however with nsis, it doesn't seem possible to do without removing the "Run BitBoxApp" checkbox, which I don't think it we should remove. Therefore, the shortcut created by default. I think this is totally acceptable behavior for Windows users. Many apps create a desktop shortcut and it is expected. For those that don't want a a shortcut, it is trivial to delete from the desktop. |
frontends/qt/setup.nsi
Outdated
| File "${ICONDIR}\icon.ico" | ||
|
|
||
| # Create a shortcut on the desktop | ||
| CreateShortCut "$DESKTOP\${APP_NAME}.lnk" "$INSTDIR\${APP_EXE}" "" "$INSTDIR\icon.ico" 0 |
There was a problem hiding this comment.
the app already embeds an icon doesn't it? can you try simply setting the icon string to "" and not copying the icon again to the install folder?
There was a problem hiding this comment.
Do you mean like this?
CreateShortCut "$DESKTOP\${APP_NAME}.lnk" "$INSTDIR\${APP_EXE}" "" "$INSTDIR\${APP_EXE}" 0
That change seems to work but I need the BBApp already installed for the logo to appear on the shortcut (I am just testing the script by compiling with NSIS).
So I think it should work but I can't fully test because I can't build the app.
There was a problem hiding this comment.
I meant to try like this:
CreateShortCut "$DESKTOP\${APP_NAME}.lnk" "$INSTDIR\${APP_EXE}" "" "" 0
There was a problem hiding this comment.
Tested and that works 👍
Will update PR
jadzeidan
force-pushed
the
nsis_shortcut
branch
from
513c119 to
a7dcab7
Compare
frontends/qt/setup.nsi
Outdated
| # Explicitly copy the icon file to the installation directory | ||
| File "${ICONDIR}\icon.ico" |
There was a problem hiding this comment.
Seems like this is not needed anymore, right?
There was a problem hiding this comment.
Correct, forgot to remove it in last update. Fixed now.
jadzeidan
force-pushed
the
nsis_shortcut
branch
from
a7dcab7 to
6bd6c31
Compare
Currently, Windows users need to manually create a desktop shortcut. This PR creates a desktop shortcut during the installation process.
Currently, Windows users need to manually create a desktop shortcut.
This PR creates a desktop shortcut during the installation process.